Bilal/list support #13
Conversation
Billalkhn
commented
Nov 30, 2020
Billalkhn
commented
- Bullet and Number Listing Feature Add.
- Serialization ad deserialization updated.
- Hotkeys For Bold, italic, underline, and code Added.
example/debug.log
Outdated
| @@ -0,0 +1 @@ | |||
| [1130/192337.441:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3) | |||
| 'mod+b': 'bold', | ||
| 'mod+i': 'italic', | ||
| 'mod+u': 'underlined', | ||
| 'mod+`': 'code', | ||
| }; |
|
there should be a way to close a list if enter key is pressed and current list-item text is empty, instead of going to toolbar every time. |
I think we can close on enter and append it on shift + enter |
Yes we can do this @Hamzaalam |
|
@Billalkhn can you do something about this PR ? we don't need a listing feature on priority as PR not merged because of some listing issues but we need Hotkeys For Bold, italic, underline, and code Added which can be extracted and merged as a new PR. |
|
I think we should to fix listing issue as well and merged this branch cuz
listing feature and hotkeys features has been almost completed just need to
fix minor issues.
…On Thu, 21 Jan 2021, 3:41 pm Hamza Alam, ***@***.***> wrote:
@Billalkhn <https://github.com/Billalkhn> can you do something about this
PR ? we don't need a listing feature on priority as PR not merged because
of some listing issues but we need Hotkeys For Bold, italic, underline, and
code Added which can be extracted and merged as a new PR.
what do you think ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMG6SETPQVUFKZP2U6IDNWDS3AAERANCNFSM4UIDK2FA>
.
|
that will be great 👍 |
